10 comments

Add a comment…

Sign in

prestine

Your email address

Check!

invalid email

(thinking…)

Reset

or sign in with

• 
• 

UserVoice password

Forgot password?

Create a password

Your name

I agree to the terms of service

Signed in as (Sign out)

Close

Close

Post comment Submitting...

• Stefan commented  ·  January 12, 2011 11:08 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  If I'm not completely mistaken, this has been implemented by now. Rails raises an exception when trying to delete a record which depends on other records:
  "ActiveRecord::DeleteRestrictionError in XYZController#destroy
  Cannot delete record because of dependent zyxs"

• PS commented  ·  April 30, 2010 4:11 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  The :restrict option would be very useful

• mbranca commented  ·  September 10, 2009 12:56 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  +3 for that option! in DRY design is ugly to have to "embed" records validation in code or create SQL statements for that!

• Jon Dahl commented  ·  August 18, 2009 5:01 p.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  ActiveRecord really should implement this. It's almost a no-brainer.

  1. It's common. Every project should maintain referential integrity in some way, and :dependent => :destroy isn't always appropriate. Who wants to do a cascading delete from roles to users, or manufacturers to products, or order_statuses to orders? I don't think I've ever worked on a project where cascading deletes were always appropriate. Any lookup table, at minimum, needs this feature.

  2. It fits with the Rails philosophy. Rails says "Let your application handle referential integrity, not the database". But without :dependent => :restrict, one of the most important pieces of referential integrity is missing.

  3. It's easy. 9 lines of code to add this to has_many. Check out this gist:

  http://gist.github.com/170059

• Adminmattetti (Admin, Rails) commented  ·  July 15, 2009 11:49 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  Rafael Bueno, please try to post in English, not everyone can read Portuguese.
  For those you can't, Rafael created a workaround to add this kind of validation.

• Rafael Bueno commented  ·  July 15, 2009 10:01 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  Eu criei uma outra forma para fazer essa válidação.

  1 - adicionei o seguinte código na minha pasta LIB

  module ModelsHelper

  # Classe com a minha exceção
  module Exceptions
  class ErrorRelashionShip < RuntimeError; end
  end

  # Inclui os métodos de válidação restrict
  module All

  include Exceptions

  # Restriction de relacionamento
  def restrict_delete(relashionship_class)
  if self.method(relashionship_class.class.to_s.pluralize.downcase).call.length > 0
  raise ErrorRelashionShip, "O registro não pode ser removido, pois têm relacionamentos"
  end
  end
  
  end
  end

  2 - Adicionei no método :before_remove da minha model, lembrando que funciona em has_and_belongs_to_many e has_many

  has_and_belongs_to_many :users, :uniq => true, :before_remove => :restrict_delete

  ou

  has_many :users, :before_remove => :restrict_delete

  3 - Adicionei o seguinte código no meu controller
  include ModelsHelper::Exceptions

  4 - Alterei o método destroy do controller
  def destroy
  @functionality = Functionality.find(params[:id])
  @functionality.destroy
  flash[:notice] = 'Funcionalidade deletada com sucesso'
  
  rescue ModelsHelper::Exceptions::ErrorRelashionShip => error
  flash[:notice] = error.message
  ensure
  redirect_to(functionalities_url)
  
  end

• Hique commented  ·  May 21, 2009 7:17 p.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  I would really like to see this in Rails. Wouldn't be better, however, implement it as a validation?

• gerjan.stokkink commented  ·  March 5, 2009 11:15 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  Heh, make that +3 :P

• gerjan.stokkink commented  ·  March 5, 2009 11:15 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  +1 for the :restrict option :)

  See also http://rails.lighthouseapp.com/projects/8994/tickets/1282-has_many-dependent-restrict.

• Stefan Kroes commented  ·  March 5, 2009 11:09 a.m.  ·  Flag as inappropriateFlag as inappropriate  ·  Delete

  :dependent => :nullify already exists on has_many associations. The :restrict options would still be very useful though.